Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks in build path for docker-compose import #9816

Merged

Conversation

surajssd
Copy link
Contributor

So when build path is resolved, or when it is being converted from relative path to absolute path, a check has been added which checks if the path is already absolute, if it is, no further operations performed and value of Build path is kept unaltered.

Fixes #9815

@surajssd surajssd changed the title Added checks in build path for docker-comspose import Added checks in build path for docker-compose import Jul 13, 2016
@surajssd surajssd force-pushed the absolute-path-docker-compose branch from bfbd542 to 8b0e2ec Compare July 13, 2016 06:32
So when build path is resolved, or when it is being converted from
relative path to absolute path, a check has been added which checks
if the path is already absolute, if it is, no further operations
performed and value of Build path is kept unaltered.

Fixes openshift#9815
@surajssd surajssd force-pushed the absolute-path-docker-compose branch from 8b0e2ec to 994857a Compare July 18, 2016 09:28
@surajssd
Copy link
Contributor Author

ping @smarterclayton

@smarterclayton
Copy link
Contributor

LGTM [merge] thanks

@smarterclayton
Copy link
Contributor

[merge]

On Tue, Jul 19, 2016 at 1:45 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge ABORTED (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6453/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9816 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_pxPT2b21tV_kSaSpxzYwjpPU3IwRks5qXQ1CgaJpZM4JLGn3
.

@smarterclayton
Copy link
Contributor

[merge]

On Tue, Jul 19, 2016 at 3:00 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6481/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9816 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p2GW-YBprnvN5lAqC985G-wUTLswks5qXR7ggaJpZM4JLGn3
.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 19, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6578/) (Image: devenv-rhel7_4631)

@surajssd
Copy link
Contributor Author

Something seems to be wrong with the test infra?

@smarterclayton
Copy link
Contributor

AWS was down. [merge]

On Wed, Jul 20, 2016 at 6:04 AM, Suraj Deshmukh [email protected]
wrote:

Something seems to be wrong with the test infra?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9816 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_px3nPtP6ZSt84ir-tOnIBKGqeGhXks5qXfK-gaJpZM4JLGn3
.

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 994857a

@openshift-bot openshift-bot merged commit ee88b4b into openshift:master Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute path in docker-compose's 'build' not supported
3 participants