deploy: set gracePeriod on deployer creation rather than when deleting #9854
Conversation
| @@ -275,6 +275,8 @@ func (c *DeploymentController) makeDeployerPod(deployment *kapi.ReplicationContr | |||
| // Assigning to a variable since its address is required | |||
| maxDeploymentDurationSeconds := deployapi.MaxDeploymentDurationSeconds | |||
|
|
|||
| gracePeriod := int64(10) | |||
There was a problem hiding this comment.
Does the deployer have to wait for child pod hooks to finish?
There was a problem hiding this comment.
On deletion I wouldn't think so.
There was a problem hiding this comment.
So the controllers will delete those hook pods?
There was a problem hiding this comment.
Yes, the deployment controller is deleting all hooks and the deployer for the deployment it is reconciling:
We also test this in unit tests, eg:
|
LGTM [merge] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 5312b9b |
|
Evaluated for origin merge up to 5312b9b |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6317/) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6316/) |
@smarterclayton