oc: add --insecure-policy for creating edge routes #9890
Conversation
|
[test] |
|
Evaluated for origin test up to f89940d |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6366/) |
| @@ -130,6 +131,11 @@ func CreateEdgeRoute(f *clientcmd.Factory, out io.Writer, cmd *cobra.Command, ar | |||
| } | |||
| route.Spec.TLS.CACertificate = string(caCert) | |||
|
|
|||
| insecurePolicy := kcmdutil.GetFlagString(cmd, "insecure-policy") | |||
| if len(insecurePolicy) > 0 { | |||
| route.Spec.TLS.InsecureEdgeTerminationPolicy = api.InsecureEdgeTerminationPolicyType(insecurePolicy) | |||
There was a problem hiding this comment.
Does it validate correctly against invalid values in insecurePolicy?
There was a problem hiding this comment.
Yes.
$ oc create route edge --service=foo --insecure-policy=Allowed --port=80
The Route "foo" is invalid.
spec.tls.insecureEdgeTerminationPolicy: Invalid value: "Allowed": invalid value for InsecureEdgeTerminationPolicy option, acceptable values are None, Allow, Redirect, or empty
|
Minor comment otherwise LGTM. |
|
Comment addressed [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6366/) (Image: devenv-rhel7_4623) |
It's taking more than 2m for the deployer to be created |
|
[merge] |
|
Evaluated for origin merge up to f89940d |
|
The frontend problem is the same as the database - secret binding is the On Tue, Jul 19, 2016 at 8:07 AM, OpenShift Bot [email protected]
|
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1354377
@fabianofranz PTAL