validate imagestreamtag names in build definitions #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Evaluated for origin test up to b77e6fa |
|
@csrwng bump |
| @@ -1762,7 +1872,7 @@ func TestValidateCommonSpec(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| // 26 | |||
| // 31 | |||
There was a problem hiding this comment.
Personally, I've started changing the test to use maps with human readable descriptions instead of indexes 😉
|
LGTM |
|
Also LGTM, but I agree we should use a name field in the struct for the test |
|
[merge] |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6618/) |
|
[merge] |
2 similar comments
|
[merge] |
|
[merge] |
|
Flake #9775. re-[merge] |
|
Evaluated for origin merge up to b77e6fa |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6746/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9923
@csrwng ptal