OCPERT-44 Check kernel tag early-kernel-stop-ship in cmd change-advisory-status #441

ming1013 · 2025-02-17T04:14:45Z

When kernel tag early-kernel-stop-ship is found, stop moving advisory status.

$ python -m unittest tests.test_advisory.TestAdvisoryManager.test_kernel_tag
/home/minl/release-tests/oar/core/util.py:27: DeprecationWarning: Function 'semver.parse_version_info' is deprecated. Deprecated since version 2.10.0. This function will be removed in semver 3. Use 'semver.version.Version.parse' instead.
semver.parse_version_info(version)
/home/minl/release-tests/oar/core/util.py:33: DeprecationWarning: Function 'semver.parse_version_info' is deprecated. Deprecated since version 2.10.0. This function will be removed in semver 3. Use 'semver.version.Version.parse' instead.
version_info = semver.parse_version_info(version)
RHCOS nvr is rhcos-x86_64-417.94.202501150123-0
The commit metadata is kernel-5.14.0-427.51.1.el9_4
Tags of this build is str[{'arches': '', 'id': 121309, 'locked': False, 'maven_include_all': False, 'maven_support': False, 'name': 'early-kernel-candidate', 'perm': None, 'perm_id': None}, {'arches': '', 'id': 121316, 'locked': False, 'maven_include_all': False, 'maven_support': False, 'name': 'early-kernel-stop-ship', 'perm': None, 'perm_id': None}, {'arches': '', 'id': 128179, 'locked': False, 'maven_include_all': False, 'maven_support': False, 'name': 'rhel-9.4.0-z-candidate', 'perm': 'rhel9-gate', 'perm_id': 81}, {'arches': '', 'id': 154307, 'locked': False, 'maven_include_all': False, 'maven_support': False, 'name': 'rhaos-4.19-rhel-9-candidate', 'perm': None, 'perm_id': None}, {'arches': '', 'id': 157969, 'locked': False, 'maven_include_all': False, 'maven_support': False, 'name': 'RHBA-2025:0354-dropped', 'perm': 'trusted', 'perm_id': 6}]
Tag of early-kernel-stop-ship is detected
check kernel tag function skipped, only image advisory need to check.
.

Ran 1 test in 23.937s

OK

…ory-status

openshift-ci · 2025-02-17T04:15:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ming1013. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ming1013 · 2025-02-17T07:37:44Z

@rioliu-rh The oar-check job failed by ModuleNotFoundError: No module named 'jq', how can we install jq in prow python env?

rioliu-rh · 2025-02-17T08:00:07Z

@rioliu-rh The oar-check job failed by ModuleNotFoundError: No module named 'jq', how can we install jq in prow python env?

release-tests/pyproject.toml

Line 29 in 977f2f8

dependencies = [

oar/core/advisory.py

tomasdavidorg

Hi @ming1013,

Just minor structure comments.

Also wouldn't be better to structure the code more. I mean extract some the 3 parts described in the jira to functions to be easily testable or separate the parts by adding some comments?

oar/core/advisory.py

tests/test_kernel_tag.py

tests/test_advisory.py

oar/cli/cmd_change_advisory_status.py

openshift-ci · 2025-02-20T13:53:22Z

@ming1013: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rioliu-rh · 2025-02-20T22:57:14Z

oar/cli/cmd_change_advisory_status.py

+        # check kernel tag before change advisories' status
+        ads = am.get_advisories()
+        for ad in ads:
+            if Advisory(errata_id=ad.errata_id, impetus=ad.impetus).check_kernel_tag():


ad is Advisory object, don't have to re-init, ref: https://github.com/openshift/release-tests/blob/master/oar/core/advisory.py#L39

rioliu-rh · 2025-02-21T00:39:17Z

oar/core/advisory.py

+        #Use koji api to query tags of this build
+        session = koji.ClientSession("https://brewhub.engineering.redhat.com/brewhub")
+        tags = session.listTags(build=rhos_meta_data)
+        logger.info(f"Tags of this build is str{tags}")


Suggested change

logger.info(f"Tags of this build is str{tags}")

logger.info(f"Tags of this build is {tags}")

rioliu-rh · 2025-02-21T00:39:59Z

oar/core/advisory.py

+        logger.info(f"Tags of this build is str{tags}")
+        for t in tags:
+            if t["name"] == 'early-kernel-stop-ship':
+                logger.info("Tag of early-kernel-stop-ship is detected")


Suggested change

logger.info("Tag of early-kernel-stop-ship is detected")

logger.info("kernel tag early-kernel-stop-ship is detected")

rioliu-rh · 2025-02-21T00:44:54Z

oar/core/advisory.py

+        """
+        #Check if impetus is image or not, if it's not image then skip this function.
+        if self.impetus != AD_IMPETUS_IMAGE:
+            logger.info("check kernel tag function skipped, only image advisory need to check.")


Suggested change

logger.info("check kernel tag function skipped, only image advisory need to check.")

logger.info("{self.impetus} advisory does not have RHCOS build, skip checking kernel tag")

rioliu-rh · 2025-02-21T00:55:17Z

oar/core/advisory.py

+        Check kernel tag from advisory build image.
+
+        Returns:
+            bool: True if kernel is tagged with early-kernel-stop-ship.


Suggested change

bool: True if kernel is tagged with early-kernel-stop-ship.

bool: True if kernel build is tagged with early-kernel-stop-ship.

rioliu-rh · 2025-02-21T00:55:53Z

oar/core/advisory.py

+        rhos_nvr_url = re.sub(r"-([\d.]+)-(\d+)$", r"/\1/\2", rhos_nvr)
+        rhos_nvr_url_full = "https://download.eng.bos.redhat.com/brewroot/packages/"+rhos_nvr_url+"/metadata.json"
+        rhos_meta_data_full = self._get(rhos_nvr_url_full)
+        rhos_meta_data = [


Suggested change

rhos_meta_data = [

kernel_build = [

OCPERT-44 Check kernel tag early-kernel-stop-ship in cmd change-advis…

c681556

…ory-status

openshift-ci bot requested review from jhuttana and ltroiano-rh February 17, 2025 04:15

fix a typo

70c6095

ming1013 requested a review from rioliu-rh February 17, 2025 04:32

rioliu-rh reviewed Feb 17, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

rioliu-rh reviewed Feb 17, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

rioliu-rh reviewed Feb 17, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

ming1013 added 4 commits February 17, 2025 18:07

add dependency and fix review comments

2401948

fix typo

8059642

add if condition branch for no rhcos nvr be got

404d116

fix a typo

5cc7192

tomasdavidorg reviewed Feb 17, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

oar/core/advisory.py Outdated Show resolved Hide resolved

oar/core/advisory.py Outdated Show resolved Hide resolved

update from ad level

f693f42

rioliu-rh reviewed Feb 19, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

rioliu-rh reviewed Feb 19, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

rioliu-rh reviewed Feb 19, 2025

View reviewed changes

oar/core/advisory.py Show resolved Hide resolved

rioliu-rh reviewed Feb 19, 2025

View reviewed changes

oar/core/advisory.py Outdated Show resolved Hide resolved

rioliu-rh reviewed Feb 19, 2025

View reviewed changes

tests/test_kernel_tag.py Outdated Show resolved Hide resolved

ming1013 added 3 commits February 19, 2025 15:30

move test function and add information log

20bcec8

move useless importing

e250359

change url for getting builds

ac228f2

rioliu-rh reviewed Feb 19, 2025

View reviewed changes

tests/test_advisory.py Outdated Show resolved Hide resolved

add assert for testing

99c032e

rioliu-rh reviewed Feb 20, 2025

View reviewed changes

oar/cli/cmd_change_advisory_status.py Outdated Show resolved Hide resolved

add advisory exception when tag found

73a2482

rioliu-rh reviewed Feb 20, 2025

View reviewed changes

rioliu-rh reviewed Feb 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPERT-44 Check kernel tag early-kernel-stop-ship in cmd change-advisory-status #441

OCPERT-44 Check kernel tag early-kernel-stop-ship in cmd change-advisory-status #441

ming1013 commented Feb 17, 2025 •

edited

Loading

openshift-ci bot commented Feb 17, 2025

ming1013 commented Feb 17, 2025

rioliu-rh commented Feb 17, 2025

tomasdavidorg left a comment •

edited

Loading

openshift-ci bot commented Feb 20, 2025

rioliu-rh Feb 20, 2025

rioliu-rh Feb 21, 2025 •

edited

Loading

rioliu-rh Feb 21, 2025

rioliu-rh Feb 21, 2025

rioliu-rh Feb 21, 2025

rioliu-rh Feb 21, 2025

	logger.info(f"Tags of this build is str{tags}")
	logger.info(f"Tags of this build is {tags}")

	logger.info("Tag of early-kernel-stop-ship is detected")
	logger.info("kernel tag early-kernel-stop-ship is detected")

	logger.info("check kernel tag function skipped, only image advisory need to check.")
	logger.info("{self.impetus} advisory does not have RHCOS build, skip checking kernel tag")

	bool: True if kernel is tagged with early-kernel-stop-ship.
	bool: True if kernel build is tagged with early-kernel-stop-ship.

OCPERT-44 Check kernel tag early-kernel-stop-ship in cmd change-advisory-status #441

Are you sure you want to change the base?

OCPERT-44 Check kernel tag early-kernel-stop-ship in cmd change-advisory-status #441

Conversation

ming1013 commented Feb 17, 2025 • edited Loading

openshift-ci bot commented Feb 17, 2025

ming1013 commented Feb 17, 2025

rioliu-rh commented Feb 17, 2025

tomasdavidorg left a comment • edited Loading

Choose a reason for hiding this comment

openshift-ci bot commented Feb 20, 2025

rioliu-rh Feb 20, 2025

Choose a reason for hiding this comment

rioliu-rh Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

rioliu-rh Feb 21, 2025

Choose a reason for hiding this comment

rioliu-rh Feb 21, 2025

Choose a reason for hiding this comment

rioliu-rh Feb 21, 2025

Choose a reason for hiding this comment

rioliu-rh Feb 21, 2025

Choose a reason for hiding this comment

ming1013 commented Feb 17, 2025 •

edited

Loading

tomasdavidorg left a comment •

edited

Loading

rioliu-rh Feb 21, 2025 •

edited

Loading