NE-1815: Activate dynamic cookies for dynamic server slots (DCM) #636
Conversation
- Introduced a "dynamic" option for "cookie" directive used on plain HTTP, edge and re-encrypt routes. This option activates the dynamic cookie creation per server, applicable only for dynamic server slots (static server slots set cookie values explicitly). Without this option, dynamic servers will not set a cookie value. - Added the "dynamic-cookie-key" directive to re-ecrypt routes to align the dynamic cookie handling across all route types (plain HTTP and edge already have "dynamic-cookie-key").This directive is used to generate a unique cookie value for a each route.
openshift-ci-robot
added
the
jira/valid-reference
|
@alebedev87: This pull request references NE-1815 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@alebedev87: This pull request references NE-1815 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@alebedev87: This pull request references NE-1815 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign |
|
@alebedev87 Generally everything looks fine to me. Tested it out too. But do you know why they put |
No idea. I agree, I don't think it makes any sense on passthrough routes. I didn't want to remove anything though, just to make the PR easier and less "destructive". Upd: may be, this was related to the implementation details of the route blueprints. They had a problem with route blueprints changing the backend name after a reload which impacted the cookie value. For, this reason they dynamically disabled the dynamic cookie for the route blueprint backends. May be, to do so, |
That's fair. We can clean up later, but it isn't hurting anything right now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] Distgit: ose-haproxy-router-base |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-haproxy-router |
Introduced a "dynamic" option for "cookie" directive used on plain HTTP, edge and re-encrypt routes. This option activates the dynamic cookie creation per server, applicable only for dynamic server slots (static server slots set cookie values explicitly). Without this option, dynamic servers will not set a cookie value.
Added the "dynamic-cookie-key" directive to re-ecrypt routes to align the dynamic cookie handling across all route types (plain HTTP and edge already have "dynamic-cookie-key").This directive is used to generate a unique cookie value for a each route.
Set-Cookieheader sent from dynamic servers before this change:and after:
Note: the dynamic cookie value is a 16 chars long hash which is different from the cookie set on the static servers (32 chars).
Previous PR on the same topic (dynamic cookies for DCM slots): openshift/origin#20557. This PR introduced "dynamic-cookie-key" directive for plain http/edge and passthrough backends in order to be able to disable the dynamic cookies for blueprint routes buy default and re-enable after a reload.