-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ffi): make using tinycc
bindings safer
#17397
Open
DonIsaac
wants to merge
26
commits into
main
Choose a base branch
from
don/chore/tcc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+791
−399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 2:13 PM PT - Feb 22nd, 2025
❌ @DonIsaac, your commit c1988a0 has 1 failures in
🧪 try this PR locally: bunx bun-pr 17397 |
190n
requested changes
Feb 17, 2025
190n
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a wrapper to all tcc bindings to convert error codes to error unions, forcing better error handling. FFI errors should be much better handled now, though there is still room for improvement.
This PR also fixes a bus error caused by running
library.close()
on any library created bycc
. Turns out we cannot free relocated memory, even if JIT write protections are disabled.How did you verify your code works?
I've added tests. These changes should still be carefully reviewed.