Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http2) fix got http2: true option #17494

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Feb 20, 2025

What does this PR do?

Fix: #15477
Only if h2 is actually supported if not will error with ERR_HTTP2_ERROR : h2 is not supported because http 1.1 fallback is not supported yet

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@cirospaciari cirospaciari marked this pull request as draft February 20, 2025 20:19
@robobun
Copy link

robobun commented Feb 20, 2025

Updated 4:28 PM PT - Feb 21st, 2025

@cirospaciari, your commit cc1046f has 5 failures in Build #12040:


🧪   try this PR locally:

bunx bun-pr 17494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got ^14.4.5 (latest version) not working on bun 1.1.37 (latest version)
2 participants