Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bun.sys more instead of std.fs #17496

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Use bun.sys more instead of std.fs #17496

wants to merge 6 commits into from

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Use bun.sys more instead of std.fs:

  • We cannot use any unreachable when reading files.
  • std.fs isn't consistently using the $NOCANCEL variants of libc functions. pread for example is used instead of pread$NOCANCEL.

How did you verify your code works?

CI. This is a somewhat risky PR if we were relying on errors from std

@robobun
Copy link

robobun commented Feb 20, 2025

Updated 2:15 PM PT - Feb 20th, 2025

@Jarred-Sumner, your commit 7a02160 has 2 failures in Build #11937:


🧪   try this PR locally:

bunx bun-pr 17496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants