Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bun/net): add TCP socket tests #17520

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Feb 21, 2025

What does this PR do?

Adds test cases for Bun.listen and Bun.connect without TLS. This PR is preparation for upcoming node:net changes.

These tests mostly focus on when/if/how event handlers get called. Tests for other APIs will be added later as needed.

How did you verify your code works?

All changed files are tests.

@robobun
Copy link

robobun commented Feb 21, 2025

Updated 11:00 AM PT - Feb 22nd, 2025

@DonIsaac, your commit 289d4a8 has 1 failures in Build #12087:


🧪   try this PR locally:

bunx bun-pr 17520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants