Revert "confine pre-commit to stages (#3940)" #4137
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Jan 2, 2024
|
Would you consider releasing this patch to minimize problems caused in old pre-commit installations as explained in the issue this PR fixes (#4065)? |
|
If you need to be unblocked before the next release is made, just use https://github.com/psf/black-pre-commit-mirror. As a happy side effect, your pre-commit will also run Black 2x faster. The mirror never received the change in #3940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4065, closes #4067, closes #4041
See comment in #4041 (comment)
The two possible fixes are both not ideal. Changing the names of the stages guarantees that things will break with new pre-commit later this year. Raising the minimum pre-commit version doesn't make things work for users who currently have issues, it just results in a better error message. Meanwhile, users who want Black to run in specific stages in pre-commit can just specify that themselves, so I think the simplest thing to do is just revert.
I'm open to trying the change later, after pre-commit has released its new breaking change and forced more folks to upgrade (and after we've released the 2024 style)