Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3963: Allow user to specify audience for OIDC authentication #3965

Closed
wants to merge 1 commit into from

Conversation

robcao
Copy link
Contributor

@robcao robcao commented Feb 18, 2025

This pull request is a potential implementation for #3963

It adds a new configuration variable for the auth_azidentity module, ARM_OIDC_AUDIENCE.

When specified, the value of ARM_OIDC_AUDIENCE will be used when making a request for a federated token. If not specified, the audience will default to api://AzureADTokenExchange like currently.

Copy link

Hi there 👋 Thank you for submitting a pull request.

Acceptance tests must be run by a maintainer. If a maintainer hasn't picked this up after 7 days, please do reach out to a maintainer via our community Slack.

Maintainers: Please review changes then run tests by adding the comment:

/run-acceptance-tests

@thomas11
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @robcao, that looks great!

thomas11 added a commit that referenced this pull request Feb 20, 2025
This PR is a copy of #3965 by @robcao, to make CI tests run. Original
description:

-----

This pull request is a potential implementation for
#3963

It adds a new configuration variable for the auth_azidentity module,
ARM_OIDC_AUDIENCE.

When specified, the value of ARM_OIDC_AUDIENCE will be used when making
a request for a federated token. If not specified, the audience will
default to api://AzureADTokenExchange like currently.

Co-authored-by: Robert Cao <[email protected]>
@thomas11 thomas11 added the resolution/fixed This issue was fixed label Feb 20, 2025
@thomas11
Copy link
Contributor

merged as #3970

@thomas11 thomas11 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants