fix: enable up to 64 chars for Kubernetes autonaming #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3031 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 4 4
======================================
Misses 4 4 ☔ View full report in Codecov by Sentry. |
thomas11
requested changes
Feb 20, 2025
| // Use default autonaming options, but set max length to 64 as allowed by Azure. | ||
| azureName: tfbridge.AutoNameWithCustomOptions(azureName, tfbridge.AutoNameOptions{ | ||
| Separator: "-", | ||
| Maxlen: 64, |
There was a problem hiding this comment.
According to #3030 is should be 63, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables generating a physical name up to 64 characters for
KubernetesClusterresources. The default currently is 24 characters.Closes: #3030