ci: Test packaging flow on Windows #13184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
type: maintenance
Most of pip's maintainers use non-Windows environments, so it's easy for our tooling to regress on Windows. Let's avoid that for our release flow. In addition, remove the dependency on the packaging job by the test jobs. The packaging job rarely fails so we aren't saving any CI resources by failing early if the packaging job fails.
ichard26
force-pushed
the
test-packaging-ci
branch
from
1197486 to
e66ad83
Compare
|
On second thought, I'm not sure how much value this adds given this won't catch subtle failures,1 but we do have a custom build script now so perhaps that's enough surface area to warrant additional testing. cc @pfmoore Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of pip's maintainers use non-Windows environments, so it's easy for our tooling to regress on Windows. Let's avoid that for our release flow.
In addition, remove the dependency on the packaging job by the test jobs. The packaging job rarely fails so we aren't saving any CI resources by failing early if the packaging job fails.
The only reason to gate the tests jobs on the packaging step would be to reduce CI failure noise when pip's packaging is broken, resulting most of the tests jobs also failing. By gating the test jobs on the packaging job, only the packaging failure would be visible, making easier to figure out the root problem. I don't think this happens much in practice though.