-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrape kubelets, cadvisor #180
Conversation
not sure about the |
scheme: https | ||
tls_config: | ||
ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt | ||
insecure_skip_verify: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? Can we get this fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we don't have kubernetes.default.svc
added to the apiservers cert's SANs. kubernetes.default
should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the insecure: skip
thingy
action: replace | ||
target_label: __scheme__ | ||
regex: https | ||
replacement: http |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still necessary to avoid Get https://198.18.0.22:10250/metrics: x509: cannot validate certificate for 198.18.0.22 because it doesn't contain any IP SANs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we can't add the whole node subnet as IPs to the certificates. So, here we need to grab the unsecured port or skip host validation
It's ready for another review @databus23 |
action: replace | ||
target_label: __scheme__ | ||
regex: https | ||
replacement: http |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we can't add the whole node subnet as IPs to the certificates. So, here we need to grab the unsecured port or skip host validation
prom scrapes kubelets, cadvisor metrics. tested in k-staging.