Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add api endpoint for commitment merging #661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add api endpoint for commitment merging #661

wants to merge 1 commit into from

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented Feb 11, 2025

Checklist:

  • I updated the documentation to describe the semantical or interface changes I introduced.

majewsky
majewsky requested changes Feb 12, 2025
View reviewed changes
@Varsius Varsius requested a review from majewsky February 19, 2025 10:10
@coveralls
Copy link

coveralls commented Feb 19, 2025 •
edited
Loading

Coverage Status

coverage: 79.638% (+0.009%) from 79.629%
when pulling a6f38ab on commitment-merging
into 866ed53 on master.

majewsky
majewsky requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a more detailed review later today or tomorrow, but for the time being, here are comments on the DB migration and model:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky requested changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

@wagnerd3 wagnerd3 Awaiting requested review from wagnerd3 wagnerd3 is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varsius @coveralls @majewsky