Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination types feat/pagination-meta #1002

Open
wants to merge 8 commits into
base: devel
Choose a base branch
from
Open

Conversation

gzukowski
Copy link
Contributor

What?
Changed the types for responses.

Why?
Current reponses were not fitting for the additional content.

Usage:

-curl "0.0.0.0:11000/api/v1/cpm/{managerId}/api/v1/all_sequences?offset=1&limit=1"

Clickup Task:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@MichalCz
Copy link
Member

MichalCz commented Dec 4, 2023

This is a breaking change for sequences running with old manager API client. Please review with extra care.

@gzukowski gzukowski force-pushed the feat/pagination-meta branch from 1ba21e5 to b70d836 Compare December 8, 2023 14:53
@alicja-gruzdz
Copy link
Contributor

alicja-gruzdz commented Dec 11, 2023

It will be released together with
#900
#1002
due to breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants