Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build MW ApiClient - iife/cjs/esm #386

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Build MW ApiClient - iife/cjs/esm #386

wants to merge 4 commits into from

Conversation

patuwwy
Copy link
Contributor

@patuwwy patuwwy commented Mar 30, 2022 •
edited
Loading

Create browser module in various format.

Bundled esm should be pointed by package.json.browser

@patuwwy patuwwy force-pushed the patch/mw-apic-browser-format branch from 53bc177 to 729be62 Compare March 30, 2022 16:14
@patuwwy patuwwy added the help wanted Extra attention is needed label Mar 30, 2022
kociolekscramjet
kociolekscramjet approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@kociolekscramjet kociolekscramjet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended :)

@patuwwy
Copy link
Contributor Author

patuwwy commented Mar 31, 2022 •
edited
Loading

@kociolekscramjet how do you use it?

@kociolekscramjet
Copy link
Contributor

need some more time for research

@jan-warchol jan-warchol changed the base branch from release/0.19 to devel April 11, 2022 08:27
@kociolekscramjet kociolekscramjet force-pushed the patch/mw-apic-browser-format branch from 729be62 to bd404eb Compare April 11, 2022 11:50
@patuwwy patuwwy marked this pull request as ready for review April 11, 2022 12:04
@patuwwy patuwwy force-pushed the patch/mw-apic-browser-format branch from 2e7334d to e8556ae Compare April 11, 2022 12:41
@patuwwy patuwwy force-pushed the patch/mw-apic-browser-format branch from e8556ae to cf2ade1 Compare April 11, 2022 13:00
@patuwwy patuwwy removed the help wanted Extra attention is needed label Apr 12, 2022
@MichalCz
Copy link
Member

@patuwwy - this is dead, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kociolekscramjet kociolekscramjet kociolekscramjet approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patuwwy @kociolekscramjet @MichalCz