Draft: Add pausing deployment rollouts #838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/pkg/handler/upgrade.go
Outdated
|
|
||
| time.AfterFunc(pauseDuration, func() { | ||
| deployment, err := clients.KubernetesClient.AppsV1().Deployments(itemNamespace).Get(context.TODO(), itemName, metav1.GetOptions{}) | ||
| if err != nil { |
There was a problem hiding this comment.
seven levels of if clauses - decrease the cyclomatic complexity
There was a problem hiding this comment.
@karl-johan-grahn Thanks for the review. The ode is really not that good. As I wrote in the issue this was just code to prove that it works. Would it be ok to add such a feature in general ? I would then of course refactor the code and add appropriate tests.
There was a problem hiding this comment.
@karl-johan-grahn I refactored the code in general:
- Reduced complexity / readability in general
- Put the code into a separate file instead of upgrade.go (separation of concerns)
- Reduced the number of changes introduced in PerformAction
- Refactor annotation to flags.go
- Add test cases for annotation and environment variable reload strategy
Could you please have a look at the changes ? Thanks in advance.
karl-johan-grahn
changed the title
tom1299
force-pushed
the
add_pause_rollout
branch
from
4f4dda5 to
8359d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this pull request is just a draft for implementing the functionality described in the enhancement #837