-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expend feature gates support to all Strimzi operators #10141
Expend feature gates support to all Strimzi operators #10141
Conversation
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run feature-gates-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
9615e5f
to
5d714a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left just one nit.
documentation/modules/operators/ref-operator-cluster-feature-gates.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple of suggestions.
documentation/modules/operators/ref-operator-cluster-feature-gates.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
Type of change
Description
This PR implements the Strimzi Proposal 74 and extends the support for Feature Gates to the User and Topic Operators. It moves the feature gate classes to the
operator-common
module, uses them in the TO and UO configuration and implements the propagation of the Feature Gates configuration from the CO to them as well.Checklist