[system test] Add wait to prevent race condition in testAutoKafkaRebalanceScaleUpSc… #10833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see-quick
changed the title
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Nov 14, 2024
im-konge
approved these changes
Nov 14, 2024
Okay one test is failing because of that's an issue you have solved in your PR. So should we proceed with the merge? Or do you want I will rebase? |
…aleDown Signed-off-by: see-quick <[email protected]>
see-quick
force-pushed
the
fix-race-condition-in-autorebalance
branch
from
32b3364 to
f2ffc22
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
added
ready for merge
OwenCorrigan76
pushed a commit
to OwenCorrigan76/strimzi-kafka-operator
that referenced
this pull request
Dec 6, 2024
…lanceScaleUpSc… (strimzi#10833) Signed-off-by: see-quick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aleDown
Type of change
Select the type of your PR
Description
This PR fixes a potential problem in our test case
testAutoKafkaRebalanceScaleUpScaleDown, where we did not wait to change the topic replicas and their partitions. I have added a wait, which should prevent such an issue.Checklist