Fix console errors #10111
Fix console errors #10111
Conversation
martmull
force-pushed
the
276-console-error-when-creating-a-new-account
branch
from
753c0f2 to
b6980aa
Compare
|
|
||
| export const TextInputV2 = forwardRef(TextInputV2WithAutoGrowWrapper); | ||
| export const TextInputV2 = TextInputV2WithAutoGrowWrapper; |
There was a problem hiding this comment.
don't we need the forwardRef anymore in some case? Not sure why we used it before?
There was a problem hiding this comment.
I can see that AddressInput is passing a ref for example to handle the focus direclty
@bosiraphael has change the component to enable autogrow but this ref should be forwared into the subcomponent TextInputV2Component
There was a problem hiding this comment.
@charlesBochet so you think I should remove the forwardRef completely?
|
Thank you! |
| @@ -45,16 +45,14 @@ export const getRecordNodeFromRecord = <T extends ObjectRecord>({ | |||
| } | |||
|
|
|||
| const nestedRecord = Object.fromEntries( | |||
| Object.entries(record) | |||
| .map(([fieldName, value]) => { | |||
| objectMetadataItem.fields | |||
There was a problem hiding this comment.
agree that we should pilot the utils by the metadata and not the record sturcture but might have a lot of side effects in this app, we need to test everything then
| @@ -79,7 +77,7 @@ export const getRecordNodeFromRecord = <T extends ObjectRecord>({ | |||
| getRecordConnectionFromRecords({ | |||
| objectMetadataItems, | |||
| objectMetadataItem: oneToManyObjectMetadataItem, | |||
| records: value as ObjectRecord[], | |||
| records: (value || []) as ObjectRecord[], | |||
There was a problem hiding this comment.
i understand the changes too, I'm not agaist them but we should add tests on these
| @@ -144,7 +142,7 @@ export const getRecordNodeFromRecord = <T extends ObjectRecord>({ | |||
| ]; | |||
| } | |||
| default: { | |||
| return [fieldName, value]; | |||
| return [fieldName, value || null]; | |||
There was a problem hiding this comment.
same here. And we should make sure that {} ends up being returned as null
|
Should we change this from draft to open? |
Solves: