Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HEVC, use ffmpeg-static #1021

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Add support for HEVC, use ffmpeg-static #1021

merged 4 commits into from
Aug 11, 2021

Conversation

codetheweb
Copy link
Contributor

Closes #629.

Changes:

  • Adds support for libx265 / HEVC
  • Switches out @ffmpeg-installer/ffmpeg for ffmpeg-static

@sindresorhus
Copy link
Contributor

Seems to work fine for me.

@codetheweb codetheweb requested a review from karaggeorge June 23, 2021 16:13
@sindresorhus
Copy link
Contributor

@karaggeorge LGTY?

karaggeorge
karaggeorge approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@karaggeorge karaggeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sindresorhus sindresorhus merged commit bc60c67 into wulkano:main Aug 11, 2021
@codetheweb codetheweb deleted the feature/hevc branch August 11, 2021 23:35
@sindresorhus sindresorhus mentioned this pull request Sep 19, 2021
Open
@jackblk jackblk mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@karaggeorge karaggeorge karaggeorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support mp4 export with HEVC encoding
3 participants
@codetheweb @sindresorhus @karaggeorge