Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Configure "FileTimeFormat" for logging and add test cases. #4658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Configure "FileTimeFormat" for logging and add test cases. #4658

wants to merge 1 commit into from
+24 −0

Conversation

louyuexing
Copy link
Contributor

Configure "FileTimeFormat" for logging and add test cases.

@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8690859) to head (aab8c38).
Report is 276 commits behind head on master.

Additional details and impacted files

see 8 files with indirect coverage changes

@kevwan
Copy link
Contributor

kevwan commented Feb 17, 2025

No assertion in test. What's the test case for?

@louyuexing
Copy link
Contributor Author

No assertion in test. What's the test case for?

Fix the test case for this issue "#4333"

@kevwan
Copy link
Contributor

kevwan commented Feb 22, 2025

Thanks for your contribution! But no check, no assertion, not a good test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louyuexing @kevwan