🐛 server: relax ShardVirtualWorkspace flag validation #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In kcp-dev#2407 we introduced this validation, but it doesn't handle the case where the VW server is not standalone, but you still want to specify --shard-virtual-workspace-url This scenario is likely when deploying a sharded environment, since you'll want the VW traffic to go via the front-proxy regardless of whether the VW server is standalone or not.
ncdc
approved these changes
Jan 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-sharded Looks like #2654 |
|
/retest |
|
/retest Appears to be stuck in merge pool, not sure if retest will help but giving it a try... |
|
/refresh |
|
/test e2e-shared Raised #2665 to track the test failure, I can't reproduce locally so I'm assuming it's a flake |
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #2407 we introduced this validation, but it doesn't handle the case where the VW server is not standalone, but you still want to specify
--shard-virtual-workspace-urlThis scenario is likely when deploying a sharded environment, since you'll want the VW traffic to go via the front-proxy regardless of whether the VW server is standalone or not.
Related issue(s)
Fixes an issue introduced via #2407