🐛 controller: use the global informer to get Shards #2660
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Looks like something happened last week and a few PRs got stuck |
I think the PR hasn't been merged because of failing FYI #2651 should deflake |
|
/close |
|
@p0lyn0mial: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@p0lyn0mial: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
p0lyn0mial
force-pushed
the
controllers_global_inf_for_shards
branch
from
a536d53 to
f77a94f
Compare
|
I rebased against the master and pushed because I wasn't sure if |
|
|
|
|
pkg/server/controllers.go
Outdated
| @@ -1274,7 +1274,7 @@ func (s *Server) installSyncTargetController(ctx context.Context, config *rest.C | |||
| c := synctargetcontroller.NewController( | |||
| kcpClusterClient, | |||
| s.KcpSharedInformerFactory.Workload().V1alpha1().SyncTargets(), | |||
| s.KcpSharedInformerFactory.Core().V1alpha1().Shards(), | |||
| s.CacheKcpSharedInformerFactory.Core().V1alpha1().Shards(), | |||
There was a problem hiding this comment.
still seeing some tests failing in test/e2e/syncer pkg. I will revert the change to synctargetcontroller controller for now.
since Shard resources are only on the root shard the apiexport controller must use the global (cached) informer othweriwse the list will always be empty on a non-root shard.
p0lyn0mial
force-pushed
the
controllers_global_inf_for_shards
branch
from
f77a94f to
01d4f40
Compare
|
/retest |
|
/test e2e-sharded |
1 similar comment
|
/test e2e-sharded |
|
/lgtm |
Summary
since Shard resources are only on the root shard all controllers must use the global (cached) informer otherwise the list will always be empty on a non-root shard.
Related issue(s)
xref: #2596