Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incorrect allocations in the system #441

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

asm582
Copy link
Contributor

@asm582 asm582 commented Feb 19, 2025

  • At scale, the InstaSlice controller is not able to handle allocations for short tasks as it relies on sub-resource status, which takes a while to update, causing different pods to use the same allocation in the system while servicing short tasks. This PR introduces a cache in the system that brings determinism into the system while servicing pods with 2-second tasks. E2E's pass in emulator and non-emulator mode, and existing unit tests pass.
  • PR also retries InstaSlice status updates in scenarios when configmap is not present but the CR needs an update

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
Copy link

openshift-ci bot commented Feb 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2025
Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@asm582 asm582 changed the title update README with installation instruction for OCP in DP (#432) Handle incorrect allocations in the system Feb 19, 2025
@asm582 asm582 marked this pull request as ready for review February 19, 2025 15:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@openshift-ci openshift-ci bot requested a review from cpmeadors February 19, 2025 15:46
@asm582
Copy link
Contributor Author

asm582 commented Feb 19, 2025

/hold until we pass e2e on Openshift

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
Copy link

openshift-ci bot commented Feb 19, 2025

@asm582: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harche
Copy link
Contributor

harche commented Feb 19, 2025

/hold until we pass e2e on Openshift

Thanks, would it be okay to wait till next week for OCP related testing? MoC cluster is busy in some DRA related tests.

@asm582
Copy link
Contributor Author

asm582 commented Feb 19, 2025

/hold until we pass e2e on Openshift

Thanks, would it be okay to wait till next week for OCP related testing? MoC cluster is busy in some DRA related tests.

Sure

@asm582 asm582 mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants