-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle incorrect allocations in the system #441
base: main
Are you sure you want to change the base?
Conversation
asm582
commented
Feb 19, 2025
•
edited
Loading
edited
- At scale, the InstaSlice controller is not able to handle allocations for short tasks as it relies on sub-resource status, which takes a while to update, causing different pods to use the same allocation in the system while servicing short tasks. This PR introduces a cache in the system that brings determinism into the system while servicing pods with 2-second tasks. E2E's pass in emulator and non-emulator mode, and existing unit tests pass.
- PR also retries InstaSlice status updates in scenarios when configmap is not present but the CR needs an update
Signed-off-by: Harshal Patil <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold until we pass e2e on Openshift |
@asm582: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thanks, would it be okay to wait till next week for OCP related testing? MoC cluster is busy in some DRA related tests. |
Sure |