Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial pod filter impl #451

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

initial pod filter impl #451

wants to merge 2 commits into from

Conversation

asm582
Copy link
Contributor

@asm582 asm582 commented Feb 20, 2025

The controller will only watch pods that have annotation - "instaslice.redhat.com/mutated" = "true"

Have tested this PR on top of #442. This PR has a dependency on 442 getting merged. E2E passes in both modes.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
Copy link

openshift-ci bot commented Feb 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
@asm582
Copy link
Contributor Author

asm582 commented Feb 20, 2025

Unit test failures will be resolved after the #442 and #441 merge.

Summarizing 3 Failures:
  [FAIL] InstasliceReconciler Reconcile Loop [It] should handle a pod having the limits defined with a valid profile
  /home/openstack/asmalvan/openshift-instaslice/issue_426/instaslice-operator/internal/controller/instaslice_controller_test.go:677
  [FAIL] InstasliceReconciler Reconcile Loop [It] should handle a pod having the limits and AllocationStatus set to Created
  /home/openstack/asmalvan/openshift-instaslice/issue_426/instaslice-operator/internal/controller/instaslice_controller_test.go:750
  [FAIL] InstasliceReconciler Reconcile Loop [It] should handle a pod having the limits and no allocation details present in the Instaslice
  /home/openstack/asmalvan/openshift-instaslice/issue_426/instaslice-operator/internal/controller/instaslice_controller_test.go:824

Ran 19 of 19 Specs in 4.891 seconds
FAIL! -- 16 Passed | 3 Failed | 0 Pending | 0 Skipped

@asm582
Copy link
Contributor Author

asm582 commented Feb 20, 2025

Solves #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant