-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46038: UPSTREAM: 129180: prevent unnecessary resolving of iscsi/fc devices to dm #2171
OCPBUGS-46038: UPSTREAM: 129180: prevent unnecessary resolving of iscsi/fc devices to dm #2171
Conversation
@RomanBednar: This pull request references Jira Issue OCPBUGS-46038, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@RomanBednar: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
f15af40
to
0943016
Compare
@RomanBednar: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
/jira refresh |
@RomanBednar: This pull request references Jira Issue OCPBUGS-46038, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
Since it has been cherry-picked into 1.32.something upstream, we can also wait until it gets merged into OCP via periodic updates. Of course, it depends on how fast we need the fix in OCP - waiting for the next periodic update will take quite some time. |
Good point, I've considered that actually. But the fix should be backported into 4.15, and upstream PR (1.27) got rejected because that's out of support already. Looking at other PRs here it seems like we do backports in o/k to "our supported branches" regardless of upstream sometimes so I'd be cherrypicking into 4.15 manually anyway. Maybe there's a better way to do it? cc @reivaj84 - do we need this fast or can we wait for the periodic update? |
@RomanBednar @jsafrane we will need this fast IMO. We have a customer that's suffering this issue and cannot workaround the problem by using the |
/retest-required |
/lgtm |
/retest-required |
/label acknowledge-critical-fixes-only |
cc @bertinatto for approval |
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
cc @tkashem Looking for anyone that can approve this PR, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1e7267c
into
openshift:master
@RomanBednar: Jira Issue OCPBUGS-46038: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-46038 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
/cherry-pick release-4.18 |
@RomanBednar: new pull request could not be created: failed to create pull request against openshift/kubernetes#release-4.18 from head openshift-cherrypick-robot:cherry-pick-2171-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.18 and openshift-cherrypick-robot:cherry-pick-2171-to-release-4.18"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.17 |
@RomanBednar: new pull request created: #2203 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.