Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage use of openshift_docker_additional_registries #8955

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Discourage use of openshift_docker_additional_registries #8955

merged 1 commit into from
Jun 29, 2018

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Jun 25, 2018 •
edited
Loading

Additional registries is a Red Hat specific set of docker patches and it's safer to rely on fully qualified image specs whenever possible so discourage reliance on openshift_docker_additional_registries

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2018
@sdodson sdodson requested review from vrutkovs and removed request for mtnbikenc June 25, 2018 14:39
This was referenced Jun 25, 2018
Closed
Closed
vrutkovs
vrutkovs approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

/skip
/refresh

@smarterclayton
Copy link
Contributor

/test gcp

@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

/cherrypick release-3.10

@openshift-cherrypick-robot
Copy link

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

/test gcp

@openshift-merge-robot openshift-merge-robot merged commit 50e9080 into openshift:master Jun 29, 2018
@openshift-cherrypick-robot
Copy link

@vrutkovs: new pull request created: #9026

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sdodson @openshift-ci-robot @smarterclayton @vrutkovs @openshift-cherrypick-robot @openshift-merge-robot