Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage reliance on openshift_docker_additional_registries #10396

Closed

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Jun 25, 2018

openshift_docker_additional_registries should not be relied on in order to configure a cluster to use an alternative registry. So remove a few areas where we advise people to configure their cluster in that manner.

openshift/openshift-ansible#8955 is related

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2018
@sdodson sdodson requested review from mburke5678 and adellape June 25, 2018 15:37
@@ -244,10 +244,13 @@ For example:
openshift_docker_additional_registries=example.com:443
----

Note: If you need to configure your cluster to use an alternate registry it's
preferred to set `oreg_url` rather than rely on `openshift_docker_additional_registries`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it's preferred to//

@@ -683,6 +682,9 @@ your own registry to be used for Docker search and Docker pull. Use the
searched. For example, `add_registry=--add-registry registry.access.redhat.com
--add-registry example.com`.

Note: If you need to configure your cluster to use an alternate registry it's
preferred to set `oreg_url` rather than rely on `openshift_docker_additional_registries`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change as above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated both.

@mburke5678
Copy link
Contributor

@sdodson A couple of nits. Otherwise LGTM. @adellape These are your files; any thoughts?

@adellape
Copy link
Contributor

Thanks, continuing via #10517.

@adellape adellape closed this Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants