Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should warn when secret keys are not valid env var names #2029

Closed
spadgett opened this issue Sep 7, 2017 · 1 comment · Fixed by #2039
Closed

Should warn when secret keys are not valid env var names #2029

spadgett opened this issue Sep 7, 2017 · 1 comment · Fixed by #2039
Assignees
@jeff-phillips-18
Labels
area/usability priority/P2

Comments

@spadgett
Copy link
Member

spadgett commented Sep 7, 2017

In the "Add to Application" dialog, we should warn when some secret keys aren't valid environment variable names. These keys will be skipped when adding env variables.

cc @beanh66
jeff-phillips-18 added a commit to jeff-phillips-18/origin-web-console that referenced this issue Sep 8, 2017
@jeff-phillips-18
Use create project popup rather than the create-project page
da39515 
Fixes openshift#2029
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Sep 8, 2017
Merged
@jeff-phillips-18
Copy link
Member

Is this enough or should we list out which variables are invalid?

image

@beanh66 @spadgett

jeff-phillips-18 added a commit to jeff-phillips-18/origin-web-console that referenced this issue Sep 8, 2017
@jeff-phillips-18
Warn when secret keys are not valid env var names
eb34522 
fixes openshift#2029
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Sep 8, 2017
Merged
jeff-phillips-18 added a commit to jeff-phillips-18/origin-web-console that referenced this issue Sep 11, 2017
@jeff-phillips-18
Warn when secret keys are not valid env var names
381269a 
fixes openshift#2029
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@jeff-phillips-18 @f0x11
Use create project popup rather than the create-project page
572de91 
Fixes openshift#2029
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@jeff-phillips-18 @f0x11
Warn when secret keys are not valid env var names
fc1ce64 
fixes openshift#2029
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@jeff-phillips-18 @f0x11
Use create project popup rather than the create-project page
0ba1ba4 
Fixes openshift#2029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
area/usability priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn when secret keys are not valid env var names jeff-phillips-18/origin-web-console
2 participants
@spadgett @jeff-phillips-18