-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1489709: Use create project popup rather than the create-project page #2035
Conversation
[test] |
app/views/projects.html
Outdated
@@ -170,7 +170,12 @@ <h2 class="h1"> | |||
OpenShift helps you quickly develop, host, and scale applications.<br> | |||
<span ng-if="canCreate">Create a project for your application.</span> | |||
</p> | |||
<a ng-if="canCreate" href="create-project" class="btn btn-lg btn-primary">Create Project</a> | |||
<div> | |||
<button ng-click="createProject($event)" class="btn btn-md btn-primary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a btn-md
(unless it's something Patternfly has added to Bootstrap).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it back to btn-lg
app/views/projects.html
Outdated
@@ -17,13 +20,10 @@ <h2 class="text-center">Loading...</h2> | |||
<h1>My Projects</h1> | |||
<div class="projects-options"> | |||
<div class="projects-add" ng-if="canCreate"> | |||
<button ng-click="createProject()" class="btn btn-md btn-primary"> | |||
<button ng-click="createProject($event)" class="btn btn-md btn-primary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment on btn-md
, although I see that was already there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the btn-md
Flake #2037 |
da39515
to
ae139e5
Compare
[merge][severity: bug] |
Evaluated for origin web console test up to ae139e5 |
Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/149/) (Base Commit: db9abb5) (PR Branch Commit: ae139e5) |
[merge][severity: bug] |
flake #2016 [merge][severity: bug] |
Evaluated for origin web console merge up to ae139e5 |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/158/) (Base Commit: a0fe3ea) (PR Branch Commit: ae139e5) (Extended Tests: bug) |
https://bugzilla.redhat.com/show_bug.cgi?id=1489709