Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1489709: Use create project popup rather than the create-project page #2035

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Sep 8, 2017

@jeff-phillips-18
Copy link
Member Author

[test]

@@ -170,7 +170,12 @@ <h2 class="h1">
OpenShift helps you quickly develop, host, and scale applications.<br>
<span ng-if="canCreate">Create a project for your application.</span>
</p>
<a ng-if="canCreate" href="create-project" class="btn btn-lg btn-primary">Create Project</a>
<div>
<button ng-click="createProject($event)" class="btn btn-md btn-primary">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a btn-md (unless it's something Patternfly has added to Bootstrap).

https://getbootstrap.com/docs/3.3/css/#buttons-sizes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it back to btn-lg

@@ -17,13 +20,10 @@ <h2 class="text-center">Loading...</h2>
<h1>My Projects</h1>
<div class="projects-options">
<div class="projects-add" ng-if="canCreate">
<button ng-click="createProject()" class="btn btn-md btn-primary">
<button ng-click="createProject($event)" class="btn btn-md btn-primary">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on btn-md, although I see that was already there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the btn-md

@spadgett
Copy link
Member

spadgett commented Sep 8, 2017

Origin Web Console Test Results: FAILURE >
(https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/148/) (Base Commit: db9abb5) (PR Branch Commit: da39515)

Flake #2037

@spadgett
Copy link
Member

spadgett commented Sep 8, 2017

[merge][severity: bug]

@spadgett spadgett changed the title Use create project popup rather than the create-project page Bug 1489709: Use create project popup rather than the create-project page Sep 8, 2017
@openshift-bot
Copy link

Evaluated for origin web console test up to ae139e5

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/149/) (Base Commit: db9abb5) (PR Branch Commit: ae139e5)

@spadgett
Copy link
Member

[merge][severity: bug]

@spadgett
Copy link
Member

flake #2016

[merge][severity: bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to ae139e5

@openshift-bot
Copy link

openshift-bot commented Sep 11, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/158/) (Base Commit: a0fe3ea) (PR Branch Commit: ae139e5) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit 240041d into openshift:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants