Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview should truncate long service class description text #2072

Closed
spadgett opened this issue Sep 13, 2017 · 3 comments
Closed

Overview should truncate long service class description text #2072

spadgett opened this issue Sep 13, 2017 · 3 comments
Assignees
@rhamilto @sg00dwin
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

We currently don't truncate the text. It's possible for a service description to be any length.
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Sep 13, 2017
@spadgett spadgett added this to the 3.7.0 milestone Sep 13, 2017
@spadgett spadgett self-assigned this Sep 13, 2017
@spadgett
Copy link
Member Author

@cdcabrera We probably want to do this on the service instance details page, too.

@spadgett
Copy link
Member Author

We might need to line clamp this instead of using the directive because otherwise we can't use the linky filter

@spadgett spadgett assigned rhamilto and sg00dwin and unassigned spadgett Sep 18, 2017
@sg00dwin sg00dwin mentioned this issue Oct 4, 2017
Merged
@rhamilto
Copy link
Member

rhamilto commented Oct 4, 2017

We probably want to do this on the service instance details page, too.

@sg00dwin, you'll want to do what you did on the overview for both the short and long description. See https://github.com/openshift/origin-web-console/blob/master/app/views/browse/service-instance.html#L70-L71

sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 5, 2017
@sg00dwin
Implement truncate-long-text for service class description and long d…
8818e16 
…escription

Fixes openshift#2072
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 5, 2017
@sg00dwin
Implement truncate-long-text for service class description and long d…
cb2f3f9 
…escription

Fixes openshift#2072
@sg00dwin sg00dwin mentioned this issue Oct 5, 2017
Merged
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 10, 2017
@sg00dwin
Implement truncate-long-text for service class description and long d…
5e5cf63 
…escription

Fixes openshift#2072
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 10, 2017
@sg00dwin
Implement truncate-long-text for service class description and long d…
c2b8d36 
…escription

Fixes openshift#2072
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 10, 2017
@sg00dwin
Implement truncate-long-text for service class description and long d…
f21bb78 
…escription

Fixes openshift#2072
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@sg00dwin @f0x11
Implement truncate-long-text for service class description and long d…
1b99a99 
…escription

Fixes openshift#2072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

@sg00dwin sg00dwin

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@rhamilto @spadgett @sg00dwin