Implement truncate-long-text for service class description and long description. #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
jeff-phillips-18
approved these changes
Oct 5, 2017
openshift-bot
added
the
needs-rebase
sg00dwin
force-pushed
the
service-description-truncation
branch
from
cb2f3f9 to
5e5cf63
Compare
|
@spadgett rebased |
spadgett
requested changes
Oct 10, 2017
| </truncate-long-text></p> | ||
| <div ng-if="row.serviceClass.externalMetadata.documentationUrl || row.serviceClass.externalMetadata.supportUrl"> | ||
| <a ng-if="row.serviceClass.externalMetadata.documentationUrl" ng-href="{{row.serviceClass.externalMetadata.documentationUrl}}" target="_blank" class="learn-more-link">View Documentation <i class="fa fa-external-link" aria-hidden="true"></i></a> | ||
| <a ng-if="row.serviceClass.externalMetadata.supportUrl" ng-href="{{row.serviceClass.externalMetadata.supportUrl}}" target="_blank" class="learn-more-link">Get Support <i class="fa fa-external-link" aria-hidden="true"></i></a> |
There was a problem hiding this comment.
Looks like a bad merge on your rebase. These should have spec in the path as above.
openshift-bot
removed
the
needs-rebase
sg00dwin
force-pushed
the
service-description-truncation
branch
from
5e5cf63 to
c2b8d36
Compare
|
@spadgett PTAL |
spadgett
requested changes
Oct 10, 2017
| </truncate-long-text></p> | ||
| <p class="service-description"><truncate-long-text | ||
| limit="500" | ||
| content="serviceClass.externalMetadata.longDescription" |
There was a problem hiding this comment.
It's now
serviceClass.spec.externalMetadata.longDescription
| <p class="pre-wrap" ng-bind-html="serviceClass.spec.externalMetadata.longDescription | linkify : '_blank'"></p> | ||
| <p class="service-description"><truncate-long-text | ||
| limit="500" | ||
| content="serviceClass.description" |
There was a problem hiding this comment.
It's now
serviceClass.spec.description
sg00dwin
force-pushed
the
service-description-truncation
branch
from
c2b8d36 to
f21bb78
Compare
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
spadgett
approved these changes
Oct 11, 2017
|
[merge] |
|
Evaluated for origin web console merge up to f21bb78 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/334/) (Base Commit: 7fd5c10) (PR Branch Commit: f21bb78) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated views
Fixes #2072
Related on openshift/origin-web-common#214