Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] stateful sets updated volume claim template selector #1144

Conversation

benjaminapetersen
Copy link
Contributor

Initial swap, will require a minor CSS change and probably some template updates elsewhere, pinging @sg00dwin to make sure changes don't cause other bugs.

Initial discussion @ this comment

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Jan 19, 2017

I think we probably just need to swap to using a class name rather than :first-child selector:

.icon-row div:first-child {
    text-align: center;
    width: 30px;
}

instead:

.icon-row .icon-wrap { 
    text-align: center;
    width: 30px;
}

to eliminate the recursion. I'm betting this will cause a good # of template updates elsewhere, though.

sg00dwin added a commit to sg00dwin/origin-web-console that referenced this pull request Jan 20, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this pull request Jan 20, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this pull request Jan 20, 2017
@benjaminapetersen benjaminapetersen deleted the statefulsets-volume-claim-template-selector branch January 23, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant