Switch to a specific class .icon-wrap instead of :first-child selector for icon-row #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <span class="fa fa-tag" aria-hidden="true"></span> | ||
| </div> | ||
| <div flex class="word-break"> | ||
| <span class="pod-template-key">Selector:</span> | ||
| <span ng-repeat="(key, value) in template.spec.selector.matchLabels"> | ||
| <!-- <span ng-repeat="(key, value) in template.spec.selector.matchLabels"> |
There was a problem hiding this comment.
I believe this block that is commented out can now be removed. The <selector selector="template.spec.selector"></selector> should cover it.
sg00dwin
force-pushed
the
icon-row-issue1088
branch
from
041ded1 to
9e2c874
Compare
sg00dwin
force-pushed
the
icon-row-issue1088
branch
from
9e2c874 to
86314b8
Compare
spadgett
approved these changes
Jan 23, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 86314b8 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/965/) (Base Commit: 880fcfc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144 (comment)
@benjaminapetersen