Skip to content

Commit

Permalink
Merge pull request #17616 from juanvallejo/jvallejo/add-selector-oc-d…
Browse files Browse the repository at this point in the history
…rain

Automatic merge from submit-queue (batch tested with PRs 17072, 17616).

Add --selector, --pod-selector flags `oc adm drain`

Fixes #17554
Fixes #17563
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525340

Picks kubernetes/kubernetes#52917, kubernetes/kubernetes#54083, and kubernetes/kubernetes#56864 to bring in `--selector` and `--pod-selector` flag support to `oc adm drain`.

cc @openshift/cli-review @deads2k @dustymabe
  • Loading branch information
openshift-merge-robot authored Dec 21, 2017
2 parents f37047b + 9f49283 commit d8c46e4
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 51 deletions.
2 changes: 2 additions & 0 deletions contrib/completions/bash/oc
Original file line number Diff line number Diff line change
Expand Up @@ -2454,6 +2454,8 @@ _oc_adm_drain()
local_nonpersistent_flags+=("--grace-period=")
flags+=("--ignore-daemonsets")
local_nonpersistent_flags+=("--ignore-daemonsets")
flags+=("--pod-selector=")
local_nonpersistent_flags+=("--pod-selector=")
flags+=("--selector=")
two_word_flags+=("-l")
local_nonpersistent_flags+=("--selector=")
Expand Down
2 changes: 2 additions & 0 deletions contrib/completions/zsh/oc
Original file line number Diff line number Diff line change
Expand Up @@ -2596,6 +2596,8 @@ _oc_adm_drain()
local_nonpersistent_flags+=("--grace-period=")
flags+=("--ignore-daemonsets")
local_nonpersistent_flags+=("--ignore-daemonsets")
flags+=("--pod-selector=")
local_nonpersistent_flags+=("--pod-selector=")
flags+=("--selector=")
two_word_flags+=("-l")
local_nonpersistent_flags+=("--selector=")
Expand Down
81 changes: 30 additions & 51 deletions vendor/k8s.io/kubernetes/pkg/kubectl/cmd/drain.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d8c46e4

Please sign in to comment.