oc adm drain no longer handles BuildControllers

[dustymabe]

Older versions of oc adm drain binary handled BuildControllers just fine. Seems like after it was upstreamed into k8s it no longer does

[root@ip-10-0-172-3 updated]# oc get bc --all-namespaces                                                          
NAMESPACE   NAME                  TYPE      FROM      LATEST                                                          
foo1        django-psql-example   Source    Git       1

[root@ip-10-0-172-3 updated]# oc adm drain --ignore-daemonsets  10.0.225.178                                      
node "10.0.225.178" already cordoned                                                                                  
error: Unknown controller kind "Build": django-psql-example-1-build; pods with local storage (use --delete-local-data to override): postgresql-1-lcdv7

Version:

[root@ip-10-0-172-3 updated]# oc version
oc v3.8.0-alpha.0+21e534e-350-dirty
kubernetes v1.8.1+0d5291c
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://10.0.172.3:8443
kubernetes v1.6.1+5115d708d7

[juanvallejo]

cc @fabianofranz @smarterclayton @deads2k

[deads2k]

@juanvallejo drain really shouldn't care what controller is dealing with a particular pod.

[smarterclayton]

Wow, that's fail.

[juanvallejo]

Per a brief discussion with @smarterclayton and David's feedback in kubernetes/kubernetes#56713 (comment):

• drain should be updated to not care about the existence of a controller (only care if a pod is managed by one)
• Pods should have an annotation / label that drain can use to decide if a pod is safe to delete or not
  • This annotation / label is set by the pod's controller.
  • If the pod does not have a controller, should a user be responsible for setting this?
• PodFilters belong in a factory