TestTriggerController is racy #17472
Assignees
Labels
Comments
mfojtik
added
component/image
kind/test-flake
|
So I have never seen a race here, so my guess is deep copy isn’t actually copying, or we’re using it incorrectly. |
|
@smarterclayton i switched the trigger controller from interface{} to runtime.Object, wonder if that messed it up... But I never seen this failure in that PR. |
|
I can’t find an earlier failure before
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17457/test_pull_request_origin_unit/6063/
What changed in master around that time?
On Nov 27, 2017, at 10:00 AM, Michal Fojtik <[email protected]> wrote:
@smarterclayton <https://github.com/smarterclayton> i switched
<d485992>
the trigger controller from interface{} to runtime.Object, wonder if that
messed it up...
But I never seen this failure in that PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17472 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p_O9vmsvBj4uz2tH3Arr9TCzjMztks5s6s6IgaJpZM4Qrsl3>
.
|
|
Found it - i think a bug in the test, never triggered before because everything ran faster/slower |
openshift-merge-robot
added a commit
that referenced
this issue
Nov 29, 2017
Automatic merge from submit-queue (batch tested with PRs 17476, 17143, 15115, 17094, 17500). Image trigger test was mutating the wrong object Fixes #17472
|
@smarterclayton not sure if related, but https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17492/test_pull_request_origin_unit/6166/ is another race... |
|
Not related, should be easy for someone to fix.
…On Wed, Nov 29, 2017 at 4:25 AM, Michal Fojtik ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton> not sure if related,
but https://openshift-gce-devel.appspot.com/build/origin-ci-
test/pr-logs/pull/17492/test_pull_request_origin_unit/6166/ is another
race...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17472 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pz0frw78RQXMk-XZkAtQePKUazQIks5s7SMCgaJpZM4Qrsl3>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seen here: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17469/test_pull_request_origin_unit/6070/
Not going to paste the 2k+ lines in output, but the race detector detected a race in that test.
@smarterclayton not sure if this is something I broke in DeepCopy() PR or something that is broken for long time...
The text was updated successfully, but these errors were encountered: