UPSTREAM: 55641: dockershim: remove corrupt checkpoints immediately upon detection

[sjenning]

kubernetes/kubernetes#55641

xref https://bugzilla.redhat.com/show_bug.cgi?id=1512717

@derekwaynecarr @eparis @jupierce

Diverges from upstream in checkpoint_store.go, since that file no longer exists upstream. The checkpoint code was migrated to pkg/kubelet/util in kubernetes/kubernetes#54085

[derekwaynecarr]

@sjenning -- this needs to be against release-3.7 and not master.

[eparis]

We need both, right?

[sjenning]

@eparis @derekwaynecarr from the meeting we just had, should I reopen this but hold it so it doesn't interfere with rebase?

[eparis]

/retest

[eparis]

re-opened to make sure we don't lose the 3.8/3.9 pick.

[eparis]

/assign @soltysh
To be merged after 1.8 rebase.

[eparis]

/lgtm
/hold

[mfojtik]

removing lgtm as upstream merges to master are on hold... please tag this when the rebase lands.

[eparis]

/retest
/lgtm
/hold

[eparis]

seth, can we get one for 3.7 as well?

[eparis]

re-added lgtm as the PR has a hold and won't merge until it is removed. The mast team agreed to 'forward pick' anything to origin/master that goes to 3.7, so this is just waiting for them to remove the hold.

[sjenning]

@eparis #17302

[soltysh]

@sjenning now that the rebase landed this is good to go, just need a reabse ;)

[soltysh]

/hold cancel

[soltysh]

@sjenning looks like you're still missing some bits, or it needs to be updated to match current level of k8s.

[sjenning]

/retest

[soltysh]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, sjenning, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS [eparis]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[deads2k]

/hold

This will conflict with #17477 and that pull is on the path to branching 3.8 and starting the 1.9 rebase. Said pull is in queue.

[deads2k]

/hold cancel

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[sjenning]

flake #17472

/retest

[openshift-ci-robot]

@sjenning: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_gce	7c46f7a	link	/test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update	7c46f7a	link	/test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17299, 17482, 17471).