Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenShift types are missing from OpenAPI and swagger endpoints #17610

Closed
jim-minter opened this issue Dec 5, 2017 · 4 comments
Closed

OpenShift types are missing from OpenAPI and swagger endpoints #17610

jim-minter opened this issue Dec 5, 2017 · 4 comments
Assignees
@mfojtik @soltysh
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/post-rebase lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P1

Comments

@jim-minter
Copy link
Contributor

jim-minter commented Dec 5, 2017 •
edited
Loading

This means that the types are missing from the API documentation https://docs.openshift.org/latest/rest_api/index.html and from any dynamically generated clients that use the OpenAPI / swagger spec. Since #17115 .
@jim-minter jim-minter self-assigned this Dec 5, 2017
@jim-minter jim-minter assigned mfojtik and unassigned jim-minter Dec 5, 2017
@jim-minter jim-minter changed the title REST API documentation missing OpenShift types OpenShift types are missing from OpenAPI and swagger endpoints Dec 5, 2017
@openshift openshift deleted a comment from openshift-ci-robot Dec 6, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Dec 6, 2017

/assign soltysh

@soltysh soltysh added kind/bug Categorizes issue or PR as related to a bug. kind/post-rebase priority/P1 labels Dec 6, 2017
@soltysh soltysh mentioned this issue Dec 8, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Dec 21, 2017
@openshift-merge-robot
Merge pull request #17688 from soltysh/issue_17610_protobuf
45ad7c2 
Automatic merge from submit-queue (batch tested with PRs 17688, 17889).

Update swagger spec generation

This updates swagger generation wrt to protobuf files. It's part of #17610, the other part openapi is still open. 

@deads2k @jim-minter ptal
@soltysh soltysh mentioned this issue Feb 5, 2018
Closed
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2018
@soltysh
Copy link
Contributor

soltysh commented Mar 7, 2018

/remove-lifecycle stale
/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 7, 2018
@soltysh
Copy link
Contributor

soltysh commented Jul 30, 2018

Just checked this again, it appears that everything is working as expected.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/post-rebase lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mfojtik @soltysh @jim-minter @openshift-bot @openshift-ci-robot