Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swagger spec generation #17688

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Update swagger spec generation #17688

merged 2 commits into from
Dec 21, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Dec 8, 2017

This updates swagger generation wrt to protobuf files. It's part of #17610, the other part openapi is still open.

@deads2k @jim-minter ptal

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2017
@jim-minter
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 14, 2017

/hold

This probably needs update after the rebase landed. I'll update it later today.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2017
@deads2k
Copy link
Contributor

deads2k commented Dec 15, 2017

/test all

/approve no-issue
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jim-minter, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh soltysh force-pushed the issue_17610_protobuf branch from 2a3a59b to 0b42dc1 Compare December 21, 2017 12:15
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 21, 2017

Rebase + regenerated files, re-applying the labels back.

@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2017
@soltysh soltysh force-pushed the issue_17610_protobuf branch from 0b42dc1 to b60a6d0 Compare December 21, 2017 13:41
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2017
@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Dec 21, 2017

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 21, 2017 •
edited
Loading

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cross b60a6d0 link /test cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17688, 17889).

@openshift-merge-robot openshift-merge-robot merged commit 45ad7c2 into openshift:master Dec 21, 2017
@soltysh soltysh deleted the issue_17610_protobuf branch December 22, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@jim-minter jim-minter

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soltysh @jim-minter @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot