UPSTREAM: 34020: Allow empty annotation values #11210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs upstream |
juanvallejo
changed the title
juanvallejo
force-pushed
the
jvallejo/allow-empty-annotation-values
branch
4 times, most recently
from
c242a8b to
4faa06a
Compare
Annotations with empty values can be used, for example, in diagnostics
logging. This patch removes the client-side check for empty values in
an annotation key-value pair.
**Before**
```
$ kubectl annotate pod zookeeper-1 node-selector="" --overwrite
error: invalid annotation format: node-selector=
```
**After**
```
$ kubectl annotate pod zookeeper-1 node-selector="" --overwrite
pod "zookeper-1" annotated
```
```
$ kubectl get po/zookeeper-1 --template='{{.metadata.annotations}}'
map[... node-selector: test-label:test]
```
juanvallejo
force-pushed
the
jvallejo/allow-empty-annotation-values
branch
from
d32a9d8 to
751d01c
Compare
|
Does this work without quotes? |
Yeah, just checked both |
|
LGTM [merge] |
|
[Test]ing while waiting on the merge queue |
juanvallejo
force-pushed
the
jvallejo/allow-empty-annotation-values
branch
from
751d01c to
94b23f9
Compare
juanvallejo
force-pushed
the
jvallejo/allow-empty-annotation-values
branch
from
94b23f9 to
cd48fb0
Compare
|
Evaluated for origin test up to cd48fb0 |
|
re[merge] |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9841/) |
|
integration test flaked on #11240 |
|
flaked on #11240 re[merge] |
|
Evaluated for origin merge up to cd48fb0 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10167/) (Base Commit: 3ed3b35) (Image: devenv-rhel7_5194) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPSTREAM: kubernetes/kubernetes#34020
Fixes:
#11175
Annotations with empty values can be used, for example, in oadm
diagnostics logging. This patch removes the client-side check for empty
values in an annotation key-value pair.
Before
After
@openshift/cli-review