Verify manifest before accepting #12182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmichalis
reviewed
Dec 8, 2016
| if err != nil { | ||
| if err != distribution.ErrBlobUnknown { | ||
| errs = append(errs, err) | ||
| } |
There was a problem hiding this comment.
You probably want to continue here otherwise you will append the error below too, right?
There was a problem hiding this comment.
Same for the schema2 handler
miminar
changed the title
miminar
force-pushed
the
first-blobs-then-manifest
branch
from
70e9f00 to
cbdcf19
Compare
|
the yum flake beast went rampage |
miminar
changed the title
|
Yum flake #8571. re-[test] |
added 2 commits
December 19, 2016 22:16
Signed-off-by: Michal Minář <[email protected]>
Mostly copied from docker/distribution repo. Signed-off-by: Michal Minář <[email protected]>
miminar
force-pushed
the
first-blobs-then-manifest
branch
from
cbdcf19 to
57f9cf6
Compare
|
Updated 1st commit to match the one in #11925. |
|
LGTM, tagging for merge after green tests. |
|
Evaluated for origin test up to 57f9cf6 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12510/) (Base Commit: 07050d7) |
|
[merge] |
|
Evaluated for origin merge up to 57f9cf6 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12510/) (Base Commit: 3c68360) (Image: devenv-rhel7_5573) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced blobs need to be checked for presence in a destination repository before accepting incoming manifest. Otherwise, user will be able to pull image without previous access to its blobs.
Resolves bz#1388018
Blocked on #11925