Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify manifest before accepting #12307

Merged

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Dec 19, 2016

Referenced blobs need to be checked for presence in a destination repository before accepting incoming manifest. Otherwise, user will be able to pull image without previous access to its blobs.

Resolves bug 1388018.

This is a cherry-pick of #12182.

@soltysh
Copy link
Contributor Author

soltysh commented Dec 19, 2016

[test]

@soltysh
Copy link
Contributor Author

soltysh commented Dec 19, 2016

@miminar
Copy link

miminar commented Dec 19, 2016

LGTM

@smarterclayton
Copy link
Contributor

[test]

@smarterclayton
Copy link
Contributor

[test] with all of the other changes

@smarterclayton
Copy link
Contributor

Still back porting breaks so I can see a green run.

@smarterclayton
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to f9cfb9b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12553/) (Base Commit: d024d12)

@smarterclayton
Copy link
Contributor

Sufficiently green, merging

@smarterclayton smarterclayton merged commit 0a7803c into openshift:release-1.3 Dec 21, 2016
@soltysh soltysh deleted the first-blobs-then-manifest-13 branch December 22, 2016 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants