to fix bugzilla 1424946 #13044
Merged
to fix bugzilla 1424946 #13044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
soltysh
suggested changes
Feb 22, 2017
| return err | ||
| if len(o.serviceAccount) > 0 { // check whether user supplied a list of SA | ||
| if len(strings.Split(o.serviceAccount, ",")) > 1 { | ||
| return fmt.Errorf("only one Service Account is supported.") |
There was a problem hiding this comment.
Just one tiny nit, not dots (.) at the end of error messages.
Merged
sdminonne
force-pushed
the
SCC_check_client
branch
from
dbc838c to
98ac517
Compare
|
@soltysh nit fixed |
|
Evaluated for origin test up to 98ac517 |
soltysh
approved these changes
Feb 22, 2017
|
LGTM [merge] |
|
Evaluated for origin merge up to 98ac517 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/423/) (Base Commit: 9f27ffa) |
|
This suffered from #13046, as well. But I'm not gonna re-kick tests. |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/474/) (Base Commit: 3f438e4) (Image: devenv-rhel7_5964) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@soltysh mind having a look?
Thanks