PSP reviews: client #13045
Merged
PSP reviews: client #13045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Flake #13046. [test] |
|
Evaluated for origin test up to 74019ec |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/472/) (Base Commit: 03e7153) |
|
LGTM |
|
+1 to all the pre-merge testing with fork ami that you guys did to get this stable for 1.5. Thanks! [merge] |
pweil-
added
the
approved
|
Evaluated for origin merge up to 74019ec |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/501/) (Base Commit: cf5b77f) (Image: devenv-rhel7_5966) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #12478 onto 1.5 branch. It also includes the last fix from here: #13044
@pweil- @mfojtik ptal
@sdminonne fyi