Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick into 1.5 of "Stop generating manuals by default" #13078

Merged
merged 4 commits into from
Feb 24, 2017
Merged

Cherry pick into 1.5 of "Stop generating manuals by default" #13078

merged 4 commits into from
Feb 24, 2017

Conversation

0xmichalis
Copy link
Contributor

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Feb 23, 2017

LGTM on green [test]

@0xmichalis
Copy link
Contributor Author

Seems like this has picked a command that is currently merging in the release-1.5 branch. Probably an artifact from me switching this from master.. Will need a rebase once #13045 merges.

@stevekuznetsov
Copy link
Contributor

@Kargakis can you explain more? What has happened? Is it a CI thing you think?

@0xmichalis
Copy link
Contributor Author

@Kargakis can you explain more? What has happened? Is it a CI thing you think?

Not at all a CI thing. Just me fighting with git. I had to pick three out of four commits and regenerate the fourth on top of the release-1.5 branch. The master branch has the extra command docs/mans that were missing from release-1.5 so during checkout I moved those in this PR too.

@0xmichalis
Copy link
Contributor Author

Not at all a CI thing. Just me fighting with git. I had to pick three out of four commits and regenerate the fourth on top of the release-1.5 branch. The master branch has the extra command docs/mans that were missing from release-1.5 so during checkout I moved those in this PR too.

Of course, I knew the job would fail and aborted it. But it can rerun now [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 26d47cf

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/507/) (Base Commit: 4a74666)

@0xmichalis
Copy link
Contributor Author

aws failure [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 26d47cf

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/549/) (Base Commit: 42bdc43) (Image: devenv-rhel7_5972)

@openshift-bot openshift-bot merged commit 4cc8555 into openshift:release-1.5 Feb 24, 2017
@0xmichalis 0xmichalis deleted the stop-generation-for-15 branch February 24, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants