Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5][BACKPORT] Pull-through using insecure transport based on tag import policy #13274

Merged
merged 5 commits into from
Mar 13, 2017
Merged

[1.5][BACKPORT] Pull-through using insecure transport based on tag import policy #13274

merged 5 commits into from
Mar 13, 2017

Conversation

miminar
Copy link

@miminar miminar commented Mar 7, 2017

Insecure istag now allows for insecure transport.

Resolves: bz#1421954

This is a backport of #13114

@mfojtik mfojtik added this to the 1.5.0 milestone Mar 7, 2017
@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@miminar miminar force-pushed the release-1.5-imageimport branch from 39089de to cc181ea Compare March 7, 2017 12:44
@miminar
Copy link
Author

miminar commented Mar 7, 2017

@mfojtik updated for #13280

@mfojtik
Copy link
Contributor

mfojtik commented Mar 7, 2017

[merge]

@miminar miminar force-pushed the release-1.5-imageimport branch from cc181ea to 35a69dd Compare March 7, 2017 16:10
@miminar
Copy link
Author

miminar commented Mar 7, 2017

The failure https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_check_future/906/consoleFull#-178241838856bf4006e4b05b79524e5923 is strange. I couldn't reproduce it locally. I've enabled debug logging in the test to get more details if it fails.

@miminar miminar force-pushed the release-1.5-imageimport branch from 35a69dd to ad2165e Compare March 7, 2017 18:06
@miminar
Copy link
Author

miminar commented Mar 7, 2017

I made the failing test more robust.

@miminar
Copy link
Author

miminar commented Mar 7, 2017

Flake #12784 in job https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/915/. re-[test].

@miminar miminar force-pushed the release-1.5-imageimport branch from ad2165e to 47f2699 Compare March 8, 2017 07:01
Michal Minář added 5 commits March 8, 2017 10:20
Cache imagestream and images during a handling of a single request
5e71d85 
Cache also created image stream.

Instead of using imagestreamimage resource, get imagestream and image
separately. This allows for later reuse of obtained objects. The
resource is still needed for signatures endpoint.

Cache remote blob getter service on the repository instead of passing it
in the context. The latter is error-prone due to a context being passed
by value by upper layers.

Signed-off-by: Michal Minář <[email protected]>
Allow remote blob access checks only for manifest PUT
43f0bdd 
Signed-off-by: Michal Minář <[email protected]>
Do the manifest verification just once
36e6855 
Disable upstream verification of manifest dependencies during manifest
PUT.

It would be preferred to let the upstream handle the verification if
they passed correct context to their manifest handler.

Also fixed race in TestBlobDescriptorServiceIsApplied.

Signed-off-by: Michal Minář <[email protected]>
Improve error message in image api helper
f901770 
Return more informartion when dockerImageConfig is not set.

Signed-off-by: Michal Minář <[email protected]>
Insecure istag allows for insecure transport
3e0d3ec 
If the imagestream lacks insecure annotaion, make sure to honor insecure
tag import policy when pulling images.

Make sure to propage the insecure flag to all repositories belonging to
the insecure registry.

When finding pullthrough candidates, make sure to consider secure
repositories first. If not found, try the insecure repositories.

Signed-off-by: Michal Minář <[email protected]>
@miminar miminar force-pushed the release-1.5-imageimport branch from 47f2699 to 3e0d3ec Compare March 8, 2017 09:20
@miminar
Copy link
Author

miminar commented Mar 8, 2017

Finally. I failed to see an error except for

FAIL	github.com/openshift/origin/pkg/dockerregistry/server	7.604s

until I found [INFO] Full output from go test logged at /openshifttmp/openshift/test-go/logs/test-go.log. In there, I found there's a data race. With that in mind I was able to reproduce locally by adding -race parameter to go test. I'm dumping my experience here in case somebody struggles with a unit test failing in jenkins and passing locally.

The race should be fixed now.

@miminar miminar mentioned this pull request Mar 8, 2017
Merged
@mfojtik
Copy link
Contributor

mfojtik commented Mar 8, 2017

[test]

@mfojtik
Copy link
Contributor

mfojtik commented Mar 8, 2017

The failure seems like GCE infra flake, so I think this is good to merge. Will give it one more chance to pass the test first.

@miminar
Copy link
Author

miminar commented Mar 8, 2017

@mfojtik just a GCE failure. This should be ready now.

@mfojtik
Copy link
Contributor

mfojtik commented Mar 8, 2017

@miminar the merge tag will fail of that GCE test is not fixed :-)

@stevekuznetsov to the rescue.

@stevekuznetsov
Copy link
Contributor

Logic does exist and used to work to detect the races in go test as races don't lead to failed tests -- I had an issue open against Go as well, they said they'd make races fail tests as well. Looks like API server never came up in GCE -- we've seen that before sometimes, I'd just re-test for now until we are harvesting more logs to get to the bottom of it.

@mfojtik
Copy link
Contributor

mfojtik commented Mar 8, 2017

@stevekuznetsov I've seen this 4x today ;-)

[test]

@stevekuznetsov
Copy link
Contributor

Nothing in the master logs that show why?

@miminar
Copy link
Author

miminar commented Mar 8, 2017

Nothing in the master logs that show why?

@stevekuznetsov I can find neither master logs nor node logs nor their configs in the artifacts. I feel kind of helpless.

@stevekuznetsov
Copy link
Contributor

That's a shame. I'll try to get better logging for us.

@miminar
Copy link
Author

miminar commented Mar 9, 2017

[test]

@miminar
Copy link
Author

miminar commented Mar 9, 2017

Unrelated failure:

05:29:53     should be applied to XFS filesystem when a pod is created [It]
05:29:53     /go/src/github.com/openshift/origin/test/extended/localquota/local_fsgroup_quota.go:149
05:29:53 
05:29:53     Expected
05:29:53         <string>: 
05:29:53     not to equal
05:29:53         <string>:

@mfojtik can we try another merge?

@miminar
Copy link
Author

miminar commented Mar 9, 2017

[test]

@mfojtik
Copy link
Contributor

mfojtik commented Mar 9, 2017

seem like another flake...

[test]

@smarterclayton
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 36e6855

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/143/) (Base Commit: cdf2521)

@miminar
Copy link
Author

miminar commented Mar 13, 2017

@mfojtik merge? 😄

@mfojtik
Copy link
Contributor

mfojtik commented Mar 13, 2017

[merge]

@miminar
Copy link
Author

miminar commented Mar 13, 2017

Yum flake while building images. @mfojtik can you get it another go?

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 13, 2017 via email

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 36e6855

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 13, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/66/) (Base Commit: e4200f3) (Image: devenv-rhel7_6067)

@openshift-bot openshift-bot merged commit 1404858 into openshift:release-1.5 Mar 13, 2017
@miminar miminar deleted the release-1.5-imageimport branch June 27, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@miminar @openshift-bot @mfojtik @stevekuznetsov @smarterclayton